London | 26-ITP-Jan | Boualem Larbi Djebbour | Sprint 1 | wireframe by djebsoft · Pull Request #1158 · CodeYourFuture/Module-Onboarding

djebsoft · 2026-02-07T13:18:11Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

making some changes to create webpage.

Questions

Updated content and structure of the wireframe HTML.

Replaced placeholder image with a new icon image.

netlify · 2026-02-07T13:18:17Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`136fbe0`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/699235b479588900081b5858
😎 Deploy Preview	https://deploy-preview-1158--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Removed starter styles and design palette comments. Updated styles for body, header, main, articles, article, and footer.

cjyuan

Can you take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

djebsoft · 2026-02-11T22:44:36Z

thank you for reviewing.
good points, I tried to fix them as follows:
I made sure my PR is well prepared
I added and edited a profile readme and willing to add more details about me later.
I completed my index.html filechecking, fixed errors (specially the

tag) then ended up with errors or warnings to show.
I completed my style.css file checking with no errors found.
I properly enhanced my code indentation using VSCode buily-in format document function.

cjyuan

Code is free of syntax error. Well done.

To better match the wireframe, can you

Layout articles 2 and 3 side by side beneath article 1
Make the image in each article span the full width of the articles?
Introduce a border around the READ MORE link
Make the image in article 1 visible

cjyuan · 2026-02-11T22:50:13Z

+  width: 100%;
+  background-color: lightyellow;
+  text-align: center;
+  padding: 0.01rem;


Can you find out how much space is 0.01rem?

cjyuan · 2026-02-11T22:52:33Z

+  <main>
+    <article>
+      <img src="https://www.nicepng.com/png/full/357-3576824_this-free-icons-png-design-of-readme-document.png" alt=""
+        style="width: 150px" />


Better practice is to separate CSS from HTML and write the CSS code in an external file.

Reduced container width and adjusted main padding.

djebsoft · 2026-02-15T03:19:55Z

thank you for reviewing
I fixed the following:
layout 2 and 3 side by side under layout 1
read more border
image 1 sorted

cjyuan · 2026-02-15T10:39:22Z

When I opened the page deployed at Netlify, I could not see the images in article 1 and 2 (see pic).

For this exercise, you can just use placeholder.svg in all three articles.

Can you use an AI tool to inspect the page content, and then fix all the typos?
In the wireframe, there is spacing between the article content and the border. On your page, however, the text and links are touching the border. Can you leave more space around the article content?

djebsoft · 2026-02-15T15:45:10Z

thanks for the review
use placeholder in all three articles.
Can you use an AI tool to fix all the typos?
I left more space around the article content?

cjyuan · 2026-02-15T16:05:55Z

To better match the wireframe image, can you
- Make the image in each article spans the full with of the article
- Align the height of the image in articles 2 and 3?
I still see some typo in the page content, can you use an AI tool to inspect the page content, and then fix all the typos?

djebsoft · 2026-02-15T21:15:33Z

than you for the notes
I made the image in each article spans the full with of the article
I the height of the image in articles 2 and 3 align
I useed an AI tool to inspect the page content, and then fix all the typos like semicolon, hyphen and article before ">" ...ect

cjyuan · 2026-02-15T21:32:16Z

Changes look good enough. Well done.

I was hoping that AI can point out, "some of the letters should be capitalised". For examples, "Git", the first letter of the first word in a sentence, title, "README".
Would be better if the image is truly centered within the article -- either no gap or same amount of gap between the image left/right edge and the left/right border of the article. (This you can change later).

djebsoft · 2026-02-15T21:41:25Z

thank you very much
I will deeply learn css again in details this time

illicitonion · 2026-05-04T17:02:15Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

djebsoft added 5 commits February 4, 2026 23:33

Revise wireframe HTML content and headings

d25e32f

Updated content and structure of the wireframe HTML.

Update wireframe image in index.html

47093f6

Replaced placeholder image with a new icon image.

Update images and text in index.html

b42ca6e

Update footer with creator information

9456100

Fix HTML structure and update links with target attribute

7bd7e9c

This comment has been minimized.

Sign in to view

djebsoft changed the title ~~Feature/wireframe~~ London | 26-ITP-Jan | Boualem Larbi Djebbour | Sprint 1 | wireframe Feb 7, 2026

This comment has been minimized.

Sign in to view

Refactor CSS by removing comments and updating styles

06e6b23

Removed starter styles and design palette comments. Updated styles for body, header, main, articles, article, and footer.

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

cjyuan reviewed Feb 8, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 8, 2026

djebsoft added 5 commits February 9, 2026 00:38

Merge branch 'CodeYourFuture:main' into feature/wireframe

2796607

Refactor HTML structure and fix tags (indentation)

253277e

Fix HTML tags and update article sections

5d3d442

Remove unnecessary section tag from index.html

9e75b35

inhanced indentation

a263d25

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026

cjyuan reviewed Feb 11, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026

djebsoft added 3 commits February 12, 2026 07:41

Fix CSS formatting by adding closing brace

3a31ce3

Increase padding in footer style

004cf3e

Refactor CSS grid layout for articles section

23b035d

djebsoft added 5 commits February 13, 2026 00:21

Change image and SVG width to 100%

5bc4b77

Refactor header styles and adjust image dimensions

f06d3e7

Update container size and main padding

8d71317

Reduced container width and adjusted main padding.

Adjust image size and header padding in CSS

ea45722

Adjust padding and grid settings in style.css

316fe0e

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026

djebsoft added 4 commits February 15, 2026 14:25

Add files via upload

1412179

Merge branch 'CodeYourFuture:main' into feature/wireframe

12b772d

Update image sources in index.html

0910808

Add left padding to article element

f981a06

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026

djebsoft added 2 commits February 15, 2026 17:54

Fix typos

9f3f43e

Fix CSS variable and update image styles

136fbe0

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026

djebsoft mentioned this pull request Feb 16, 2026

ITP_Jan_2026 | Onboarding | Boualem Larbi Djebbour djebsoft/My-Coursework-Planner#3

Open

illicitonion closed this May 4, 2026

djebsoft mentioned this pull request May 12, 2026

London | 26-ITP-May | Boualem Larbi Djebbour | Sprint 2 | wireframe #1255

Open

4 tasks

Uh oh!

Conversation

djebsoft commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

netlify Bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

djebsoft commented Feb 11, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

djebsoft commented Feb 15, 2026

Uh oh!

cjyuan commented Feb 15, 2026

Uh oh!

djebsoft commented Feb 15, 2026

Uh oh!

cjyuan commented Feb 15, 2026

Uh oh!

djebsoft commented Feb 15, 2026

Uh oh!

cjyuan commented Feb 15, 2026

Uh oh!

djebsoft commented Feb 15, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

djebsoft commented Feb 7, 2026 •

edited

Loading

netlify Bot commented Feb 7, 2026 •

edited

Loading